| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120421104627.GD24211@n2100.arm.linux.org.uk> Date: Sat, 21 Apr 2012 11:46:27 +0100 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Alexander Shiyan <shc_work@...l.ru> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 12/17] ARM clps711x: Simple optimise debug_macro by removing one NOP On Sat, Apr 21, 2012 at 01:11:25PM +0400, Alexander Shiyan wrote: > > Signed-off-by: Alexander Shiyan <shc_work@...l.ru> > --- > arch/arm/mach-clps711x/include/mach/debug-macro.S | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-clps711x/include/mach/debug-macro.S b/arch/arm/mach-clps711x/include/mach/debug-macro.S > index 118b3d9..37c4d8a 100644 > --- a/arch/arm/mach-clps711x/include/mach/debug-macro.S > +++ b/arch/arm/mach-clps711x/include/mach/debug-macro.S > @@ -14,10 +14,8 @@ > #include <mach/hardware.h> > > .macro addruart, rp, rv, tmp > -#ifndef CONFIG_DEBUG_CLPS711X_UART2 > - mov \rp, #0x0000 @ UART1 > -#else > - mov \rp, #0x1000 @ UART2 > +#ifdef CONFIG_DEBUG_CLPS711X_UART2 > + mov \rp, #0x1000 @ Add offset for UART2 base reg > #endif This looks wrong. How is rp initialized if CONFIG_DEBUG_CLPS711X_UART2 is not set? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists