linux-kernel - Re: [PATCH 12/17] ARM clps711x: Simple optimise debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201204211149.47404.arnd@arndb.de>
Date:	Sat, 21 Apr 2012 11:49:47 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org, Alexander Shiyan <shc_work@...l.ru>
Subject: Re: [PATCH 12/17] ARM clps711x: Simple optimise debug_macro by removing one NOP

On Saturday 21 April 2012, Arnd Bergmann wrote:
> 
> On Saturday 21 April 2012, Alexander Shiyan wrote:
> > 
> >                 .macro  addruart, rp, rv, tmp
> > -#ifndef CONFIG_DEBUG_CLPS711X_UART2
> > -               mov     \rp, #0x0000    @ UART1
> > -#else
> > -               mov     \rp, #0x1000    @ UART2
> > +#ifdef CONFIG_DEBUG_CLPS711X_UART2
> > +               mov     \rp, #0x1000    @ Add offset for UART2 base reg
> >  #endif
> >                 orr     \rv, \rp, #CLPS711X_VIRT_BASE
> >                 orr     \rp, \rp, #CLPS711X_PHYS_BASE
> 
> This looks wrong at first sight. Is rp guaranteed to be zero when calling
> the macro? Am I misreading this? Sorry my ARM assembly skill is still horrible.

Ah, Russell was faster to point out the same problem. Well I'm glad that
I sometimes read the assembly correctly then ;-)

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/