linux-kernel - Re: [PATCH 03/13] clk: CLK_PREPARE must depend on HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120421124043.GG24211@n2100.arm.linux.org.uk>
Date:	Sat, 21 Apr 2012 13:40:43 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Viresh Kumar <viresh.linux@...il.com>
Cc:	akpm@...ux-foundation.org, mturquette@...aro.org,
	sshtylyov@...sta.com, spear-devel@...t.st.com,
	linux-kernel@...r.kernel.org, jgarzik@...hat.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 03/13] clk: CLK_PREPARE must depend on HAVE_CLK

On Sat, Apr 21, 2012 at 05:17:30PM +0530, Viresh Kumar wrote:
> CLK_PREPARE must have dependency on HAVE_CLK. Add it.

No - its possible to have HAVE_CLK_PREPARE selected independently of
HAVE_CLK.  Why do we want to end up having to add conditionals all
over the place for 'select HAVE_CLK_PREPARE' ?

The only time HAVE_CLK_PREPARE gets used is in a header file, where you're
already making it conditional on HAVE_CLK.  Nothing else should know about
HAVE_CLK_PREPARE.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/