linux-kernel - Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMLZHHR-dBipjzNB2cFM_AUcj6=rr4qSX0Pp6jcsvvV+iU1w=Q@mail.gmail.com>
Date:	Sat, 21 Apr 2012 09:03:01 -0600
From:	Daniel Drake <dsd@...top.org>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Peter Hutterer <peter.hutterer@...-t.net>,
	"X.Org Devel List" <xorg-devel@...ts.freedesktop.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: Multitouch regression in 3.3 on thinkpad X220 clickpad

On Fri, Apr 20, 2012 at 6:16 PM, Benjamin Herrenschmidt
<benh@...nel.crashing.org> wrote:
>> It looks we lost a condition in synaptics_set_advanced_gesture_mode().
>> It used to be:
>>
>>
>>       if (!(SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) ||
>>                       SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c)))
>>               return 0;
>>
>> and now simply is:
>>
>>       if (!SYN_CAP_ADV_GESTURE(priv->ext_cap_0c))
>>               return 0;
>>
>> Could you try restoring the condition and see if it fixes the
>> regression?
>
> Yes, that's it. Please shoot the patch below to Linus.

Oops. Thanks Ben and Dmitry, and apologies for causing this bug.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/