linux-kernel - Re: [PATCH 3/3] staging: olpc_dcon.c: Remove a few spaces between casts and variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120421202825.GW6498@mwanda>
Date:	Sat, 21 Apr 2012 23:28:25 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	Valentin Rothberg <valentinrothberg@...glemail.com>,
	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Jordan Crouse <jordan@...micpenguin.net>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Andres Salomon <dilinger@...ued.net>,
	Chris Ball <cjb@...top.org>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 3/3] staging: olpc_dcon.c: Remove a few spaces between
 casts and variables

On Sat, Apr 21, 2012 at 08:33:15PM +0200, Jesper Juhl wrote:
> Just a trivial style cleanup.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  drivers/staging/olpc_dcon/olpc_dcon.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index 7fe6eb6..992275c 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -134,7 +134,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int is_powered_down)
>  power_up:
>  	if (is_powered_down) {
>  		x = 1;
> -		x = olpc_ec_cmd(0x26, (unsigned char *) &x, 1, NULL, 0);
> +		x = olpc_ec_cmd(0x26, (unsigned char *)&x, 1, NULL, 0);
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This will only work on little endian systems btw.  On big endian
systems the first byte is going to be 0x00 instead of 0x01.

>  		if (x) {
>  			printk(KERN_WARNING "olpc-dcon:  unable to force dcon to power up: %d!\n",
>  				x);

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/