linux-kernel - Re: [PATCH] Fixed atleast coding style issues relating spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1204212315150.25551@swampdragon.chaosbits.net>
Date:	Sat, 21 Apr 2012 23:19:22 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Jeffrin Jose <ahiliation@...oo.co.in>
cc:	tiwai@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixed atleast coding style issues relating spaces

On Sun, 22 Apr 2012, Jeffrin Jose wrote:

> hello 
> 
> I have fixed atleast coding style issues relating
> spaces in file sound/usb/card.c
> 
> Please see attachment.
> 

ok, So I took a quick look at the patch and I think it looks fine. So as 
far as that goes, feel free to add
  Acked-by: Jesper Juhl <jj@...osbits.net>

but you really should try to send patches inline rather than as 
attachments. Attachments are a pain when you want to reply and quote and 
comment on the patch.

As far as the mail (patch) subject goes, I also feel a need to comment; 
what's up with "atleast"? Shouldn't it just be
"Fixed coding style issues relating to spaces" ??

Anyway, the actual change looks good to me.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/