linux-kernel - Re: [PATCH 1/1] mmap.c: find_vma: remove unnecessary if(mm) check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHGf_=ovyXxNwc8o=MjL9-6eReCA2UzDvLeLMqEHVPxiLiKOPQ@mail.gmail.com>
Date:	Sat, 21 Apr 2012 19:48:27 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Rajman Mekaco <rajman.mekaco@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Kautuk Consul <consul.kautuk@...il.com>
Subject: Re: [PATCH 1/1] mmap.c: find_vma: remove unnecessary if(mm) check

On Sat, Apr 21, 2012 at 9:42 AM, Rajman Mekaco <rajman.mekaco@...il.com> wrote:
> The if(mm) check is not required in find_vma, as the kernel
> code calls find_vma only when it is absolutely sure that the
> mm_struct arg to it is non-NULL.
>
> Removing the if(mm) check and adding the a WARN_ONCE(!mm)
> for now.
> This will serve the purpose of mandating that the execution
> context(user-mode/kernel-mode) be known before find_vma is called.
> Also fixed 2 checkpatch.pl errors in the declaration
> of the rb_node and vma_tmp local variables.
>
> I was browsing through the internet and read a discussion
> at https://lkml.org/lkml/2012/3/27/342 which discusses removal
> of the validation check within find_vma.
> Since no-one responded, I decided to send this patch with Andrew's
> suggestions.
>
> Signed-off-by: Rajman Mekaco <rajman.mekaco@...il.com>
> Cc: Kautuk Consul <consul.kautuk@...il.com>

Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/