lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 21 Apr 2012 07:28:38 +0100 From: Al Viro <viro@...IV.linux.org.uk> To: Konstantin Khlebnikov <khlebnikov@...nvz.org> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] fs: fix integer overflow in MS_NOUSER definition On Sat, Apr 21, 2012 at 09:49:49AM +0400, Konstantin Khlebnikov wrote: > MS_NOUSER defined as signed int (1<<31), sb->s_flags declared as unsigned long. > So (sb->s_flags & MS_NOUSER) works as (sb->s_flags & 0xffffffff80000000). ... and it's not a problem since we can't use bits 32 and above anyway - unsigned long is 32bit on a lot of platforms. I have no objections to making that 1U<<31, but it's not a bug, let alone an integer overflow. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists