linux-kernel - Re: [PATCH v4] iio: Add device tree support to LPC32xx ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120421034204.GA9142@game.jcrosoft.org>
Date:	Sat, 21 Apr 2012 05:42:04 +0200
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Roland Stigge <stigge@...com.de>
Cc:	jic23@....ac.uk, gregkh@...uxfoundation.org,
	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, arm@...nel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4] iio: Add device tree support to LPC32xx ADC

On 21:48 Fri 20 Apr     , Roland Stigge wrote:
> This patch adds device tree support to the LPC32xx's ADC.
> 
> Signed-off-by: Roland Stigge <stigge@...com.de>
> 
> ---
> 
> Applies to v3.4-rc3
> 
> Changes since v3:
> * Changed "compatible" strings to non-wildcard versions
> 
> Thanks to Arnd Bergmann and Lars-Peter Clausen for reviewing!
> 
>  Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt |   17 ++++++++++
>  drivers/staging/iio/adc/lpc32xx_adc.c                             |   13 +++++++
>  2 files changed, 30 insertions(+)
> 
> --- /dev/null
> +++ linux-2.6/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
> @@ -0,0 +1,17 @@
> +* NXP LPC32xx SoC ADC controller
> +
> +Required properties:
> +- compatible: must be "nxp,lpc3220-adc", "nxp,lpc3230-adc", "nxp,lpc3240-adc"
> +  or "nxp,lpc3250-adc"
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +- interrupts: The ADC interrupt
> +
> +Example:
> +
> +	adc@...48000 {
> +		compatible = "nxp,lpc3250-adc";
> +		reg = <0x40048000 0x1000>;
> +		interrupt-parent = <&mic>;
> +		interrupts = <39 0>;
> +	};
> --- linux-2.6.orig/drivers/staging/iio/adc/lpc32xx_adc.c
> +++ linux-2.6/drivers/staging/iio/adc/lpc32xx_adc.c
> @@ -30,6 +30,7 @@
>  #include <linux/clk.h>
>  #include <linux/err.h>
>  #include <linux/completion.h>
> +#include <linux/of.h>
>  
>  #include "../iio.h"
>  #include "../sysfs.h"
> @@ -221,12 +222,24 @@ static int __devexit lpc32xx_adc_remove(
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id lpc32xx_adc_match[] = {
> +	{ .compatible = "nxp,lpc3220-adc" },
> +	{ .compatible = "nxp,lpc3230-adc" },
> +	{ .compatible = "nxp,lpc3240-adc" },
> +	{ .compatible = "nxp,lpc3250-adc" },
do you really need to list them all?


if they are all cmpatible just list the first one

Best Regards,
J.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/