linux-kernel - Re: [PATCH 0/3] hid: Enable report fixup on rebind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1204222325380.1856@pobox.suse.cz>
Date:	Sun, 22 Apr 2012 23:27:04 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nikolai Kondrashov <spbnick@...il.com>
Subject: Re: [PATCH 0/3] hid: Enable report fixup on rebind

On Sun, 22 Apr 2012, Henrik Rydberg wrote:

> This patchset contains a resolution to the problem with
> driver-specific modification of the report descriptor. The core of the
> problem lies with the dual semantics of hid_parse_report(), which is
> therefore split into two functions. As a consequence, the hid core can
> handle the rebind case internally, with no changes to the
> drivers. Out-of-tree drivers will work fine as long as they operate in
> the same way as the in-kernel drivers.
> 
> The first two patches are bug fixes found in the process. I am hoping
> for some test feedback on those. The third patch is the main one.

Hi Henrik,

thanks a lot for looking into this. I will look into the patches in more 
detail tomorrow. I am now just adding Nikolai to CC, as he was the first 
one to bring this up and actually has a driver that exposed the fact that 
just freeing/reinstatiating rdesc is not enough.

Thanks!

> 
> Henrik Rydberg (3):
>   hid-hyperv: Do not use hid_parse_report() directly
>   hid-logitech: Collect report descriptors before sending
>   hid: Handle driver-specific device descriptor in core
> 
>  drivers/hid/hid-core.c        |  112 +++++++++++++++++++++++++++++++++--------
>  drivers/hid/hid-hyperv.c      |   14 +++++-
>  drivers/hid/hid-logitech-dj.c |   71 +++++++++++---------------
>  include/linux/hid.h           |   14 ++----
>  4 files changed, 135 insertions(+), 76 deletions(-)
> 
> -- 
> 1.7.10
> 

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/