linux-kernel - [PATCH] drivers/block/cpqarray.c: add missing cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Apr 2012 11:15:12 +0200
From:	Julia Lawall <Julia.Lawall@...6.fr>
To:	Chirag Kantharia <chirag.kantharia@...com>
Cc:	kernel-janitors@...r.kernel.org, iss_storagedev@...com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] drivers/block/cpqarray.c: add missing cmd_free

From: Julia Lawall <Julia.Lawall@...6.fr>

Call cmd_free(h, c, 0); before leaving the function as done on all other
exit paths.

Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

---
 drivers/block/cpqarray.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 9125bbe..db6f15d 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1334,6 +1334,7 @@ static int ida_ctlr_ioctl(ctlr_info_t *h, int dsk, ida_ioctl_t *io)
 	case READ_FLASH_ROM:
 		if (copy_to_user(io->sg[0].addr, p, io->sg[0].size)) {
 			kfree(p);
+			cmd_free(h, c, 0);
 			return -EFAULT;
 		}
 		/* fall through and free p */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/