linux-kernel - Re: [CRIU] [PATCH v2 0/2] IPC: message queue checkpoint/restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Apr 2012 14:19:25 +0400
From:	Kinsbursky Stanislav <skinsbursky@...nvz.org>
To:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
CC:	"serge.hallyn@...onical.com" <serge.hallyn@...onical.com>,
	"dhowells@...hat.com" <dhowells@...hat.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"lucas.demarchi@...fusion.mobi" <lucas.demarchi@...fusion.mobi>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"criu@...nvz.org" <criu@...nvz.org>,
	"mtk.manpages@...il.com" <mtk.manpages@...il.com>
Subject: Re: [CRIU] [PATCH v2 0/2] IPC: message queue checkpoint/restore -
 requested updates

Hello, Andrew.
I'm very sorry, but a critical flaw has been found in this feature: copying of 
kernel data to user is done under spinlock.
Since message queue size can be increased up to INT_MAX, then copying to 
temporary kernel buffer while passing message queue in not a solution.
So, please, drop both patches (feature implementation and test).
Most probably Ill replace them with MSG_PEEK feature (the same logic, but only 
for one message - like it's done for sockets).

-- 
Best regards,
Stanislav Kinsbursky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/