linux-kernel - Re: [PATCH 12/16] rtmutex: turn the plist into an rb-tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Apr 2012 07:37:57 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Juri Lelli <juri.lelli@...il.com>, tglx@...utronix.de,
	mingo@...hat.com, oleg@...hat.com, fweisbec@...il.com,
	darren@...art.com, johan.eker@...csson.com, p.faure@...tech.ch,
	linux-kernel@...r.kernel.org, claudio@...dence.eu.com,
	michael@...rulasolutions.com, fchecconi@...il.com,
	tommaso.cucinotta@...up.it, nicola.manica@...i.unitn.it,
	luca.abeni@...tn.it, dhaval.giani@...il.com, hgu1972@...il.com,
	paulmck@...ux.vnet.ibm.com, raistlin@...ux.it,
	insop.song@...csson.com, liming.wang@...driver.com
Subject: Re: [PATCH 12/16] rtmutex: turn the plist into an rb-tree.

On Mon, 2012-04-23 at 10:33 +0200, Peter Zijlstra wrote:
> On Wed, 2012-04-11 at 17:11 -0400, Steven Rostedt wrote:
> > 
> > I have to ask. Why not just add a rbtree with a plist? That is, add all
> > deadline tasks to the rbtree and all others to the plist. As plist has a
> > O(1) operation, and rbtree does not. We are making all RT tasks suffer
> > the overhead of the rbtree.
> 
> You always love to add complexity to stuff before making it work, don't
> you ;-)

Nah, I like the make it work first, then optimize. But I wanted to bring
this up as a concern. After benchmarks, it may not be an issue anyway. I
just don't want to forget about doing the benchmarks.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/