linux-kernel - Re: commit 1cb41fe7e34a43a1d27dfdb6d65699786dd44c20 in stable (v3.3.3) breaks perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120423162547.GA27669@kroah.com>
Date:	Mon, 23 Apr 2012 09:25:48 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Zeev Tarantov <zeev.tarantov@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: commit 1cb41fe7e34a43a1d27dfdb6d65699786dd44c20 in stable
 (v3.3.3) breaks perf

On Mon, Apr 23, 2012 at 09:37:04AM +0300, Zeev Tarantov wrote:
> gcc correctly complains:
> 
> util/hist.c: In function ‘__hists__add_entry’:
> util/hist.c:240:27: error: invalid type argument of ‘->’ (have ‘struct hist_entry’)
> util/hist.c:241:23: error: invalid type argument of ‘->’ (have ‘struct hist_entry’)
> 
> for this new code:
> 
> +                       if (he->ms.map != entry->ms.map) {
> +                               he->ms.map = entry->ms.map;
> +                               if (he->ms.map)
> +                                       he->ms.map->referenced = true;
> +                       }
> 
> because "entry" is a "struct hist_entry", not a pointer to a struct.
> 
> In mainline, "entry" is a pointer to struct passed as argument to the function.
> So this is broken during backporting. But obviously not compile tested. 
> Greg wrote on G+ that those who did not test 3.3.3-rc1 have no right to complain, but I'm complaining anyway. :P
> 
> See trivial patch to fix this.
> -Z.T.
> 
> P.S.
> I don't need credit for the patch so it's ok if my diff doesn't apply because of messed up whitespace.
> Just fix it.

Patch looks good to me, thanks for doing this, you are right in that I
didn't test perf.  I'll go queue this up right now.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/