linux-kernel - Re: [PATCH 1/2] i2c: mux: add device tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Apr 2012 19:00:26 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Ben Dooks <ben-linux@...ff.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	devicetree-discuss@...ts.ozlabs.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, Stephen Warren <swarren@...dia.com>,
	David Daney <ddaney.cavm@...il.com>
Subject: Re: [PATCH 1/2] i2c: mux: add device tree support

On Mon, Apr 23, 2012 at 10:13:19AM -0600, Stephen Warren wrote:
> On 04/23/2012 05:15 AM, Wolfram Sang wrote:
> > On Tue, Apr 17, 2012 at 12:49:04PM -0600, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@...dia.com>
> >>
> >> * Define core portions of the DT binding for I2C bus muxes.
> >> * Enhance i2c_add_mux_adapter():
> >> ** Add parameters required for DT support. Update all callers.
> >> ** Set the appropriate adap->dev.of_node for the child bus.
> >> ** Call of_i2c_register_devices() for the child bus.
> >>
> >> Signed-off-by: Stephen Warren <swarren@...dia.com>
> > 
> > David Daney (CCed) posted another variant [1]. Just looking at the
> > patches (and not really using them), I tend to like the approach using
> > <reg> better. But I am open for discussion, so I'd appreciate your
> > feedback.
> > 
> > Regards,
> > 
> >    Wolfram
> > 
> > [1] http://lkml.org/lkml/2012/4/12/423
> 
> Ah, that does look like a reasonable binding.

May I interpret this as an ack? :)

> to be listed last in pinctrl-names (if it's listed at all). I'll update
> my patches based on that David's patch.

Thanks.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)