linux-kernel - Re: [PATCH][Trivial] lib/kobject.c: Remove redundant check in populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120423204322.GE13075@kroah.com>
Date:	Mon, 23 Apr 2012 13:43:22 -0700
From:	greg <gregkh@...uxfoundation.org>
To:	yan <clouds.yan@...il.com>
Cc:	kernel <linux-kernel@...r.kernel.org>,
	message <message.get@...il.com>
Subject: Re: [PATCH][Trivial] lib/kobject.c: Remove redundant check in
 populate_dir

On Sat, Apr 21, 2012 at 06:18:25PM +0800, yan wrote:
> create_dir will call sysfs_create_dir and then populate_dir.
> If ktype of kobject is null, sysfs_craete_dir will lead to
> oops first. There is no need to check ktype in populate_dir.
> 
> Signed-off-by: Yan Hong <clouds.yan@...il.com>
> ---
>  lib/kobject.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/kobject.c b/lib/kobject.c
> index bc05922..85d5e9b 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -34,7 +34,7 @@ static int populate_dir(struct kobject *kobj)
>  	int error = 0;
>  	int i;
>  
> -	if (t && t->default_attrs) {
> +	if (t->default_attrs) {

I don't know, I think I'd like to keep this check for now, as it was put
there for a reason.  Yes, it's a reason lost to the sands of time, but
is it costing us anything if it is still there?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/