linux-kernel - Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Apr 2012 14:53:01 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Rob Lee <rob.lee@...aro.org>,
	Amit Kucheria <amit.kucheria@...aro.org>,
	kernel@...gutronix.de, linaro-dev@...ts.linaro.org,
	patches@...aro.org, daniel.lezcano@...aro.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] ARM: imx: Add common imx cpuidle init functionality.

On Mon, Apr 23, 2012 at 08:27:39AM +0200, Sascha Hauer wrote:
> On Mon, Apr 23, 2012 at 01:18:21PM +0800, Shawn Guo wrote:
> > On Sun, Apr 22, 2012 at 11:44:39PM -0500, Rob Lee wrote:
> > > >> I don't think we need a cpu_is_imx6q(), but having some i.MX6 specific
> > > >> hook at device_initcall time can't be too wrong. Shawn?
> > > >>
> > > > Yep, it works for me.
> > > >
> > > Sascha, Shawn, thanks for the response.
> > > 
> > > Since device_initcall isn't platform specific, it seems I would still
> > > need a cpu_is_imx6q() function or similiar functionality from a device
> > > tree call.  Or do you have something else in mind that I'm not seeing?
> > > 
> > I guess Sascha is asking for something like the following.
> > 
> > static int __init imx_device_init(void)
> > {
> > 	imx5_device_init();
> > 	imx6_device_init();
> > }
> > device_initcall(imx_device_init)
> > 
> > static int __init imx6_device_init(void)
> > {
> > 	/*
> > 	 * do whatever needs to get done in device_initcall time
> > 	 */
> > }
> 
> The problem is more how we can detect that we are actually running a
> i.MX6 SoC. We could directly ask the devicetree in an initcall or we
> could introduce a cpu_is_mx6() just like we have a macro for all other
> i.MX SoCs.
> 
Oops, my reply was a brain-dead one.  Hmm, then it seems that we have
to introduce cpu_is_mx6() which I tried hard to avoid.  I do not have
a preference between defining a macro and asking device tree.

-- 
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/