linux-kernel - Re: [PATCH] DLS: cleanup clearing overload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F94FD66.2050707@gmail.com>
Date:	Mon, 23 Apr 2012 08:57:42 +0200
From:	Juri Lelli <juri.lelli@...il.com>
To:	Hillf Danton <dhillf@...il.com>
CC:	Dario Faggioli <raistlin@...ux.it>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] DLS: cleanup clearing overload

On 04/08/2012 01:33 PM, Hillf Danton wrote:
> We have to info puller that there is no more diet, even if CPU goes off.
>
> Signed-off-by: Hillf Danton<dhillf@...il.com>
> ---
>
> --- a/kernel/sched_dl.c	Sat Apr  7 15:00:28 2012
> +++ b/kernel/sched_dl.c	Sun Apr  8 19:24:30 2012
> @@ -83,9 +83,6 @@ static inline void dl_set_overload(struc
>
>   static inline void dl_clear_overload(struct rq *rq)
>   {
> -	if (!rq->online)
> -		return;
> -

This check should have been inserted in -rt with this:
http://lists-archives.com/linux-kernel/15208730-sched-fix-cpupri-hotplug-support.html
As stated in the changlog, it was inserted to resolve a
bug related to hotplug. Most probably the same problem
would affect us, so I would not remove that check.

Thanks,

- Juri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/