linux-kernel - Re: [PATCH 5/9 v2] gpio/nomadik: use ioremap() instead of static mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda=aUFyZ2M3wAWSNzuk4EwGNRbo-qqtxLA26PeRKRtTog@mail.gmail.com>
Date:	Tue, 24 Apr 2012 09:38:17 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Rabin Vincent <rabin.vincent@...ricsson.com>,
	Jonas Aberg <jonas.aberg@...ricsson.com>,
	Philippe LANGLAIS <philippe.langlais@...ricsson.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 5/9 v2] gpio/nomadik: use ioremap() instead of static mappings

On Mon, Apr 23, 2012 at 1:34 PM, Russell King - ARM Linux
<linux@....linux.org.uk> wrote:
> On Mon, Apr 23, 2012 at 01:30:32PM +0200, Linus Walleij wrote:
>> diff --git a/drivers/gpio/gpio-nomadik.c b/drivers/gpio/gpio-nomadik.c
>> index 7b45d88..bddc3dd 100644
>> --- a/drivers/gpio/gpio-nomadik.c
>> +++ b/drivers/gpio/gpio-nomadik.c
>> @@ -28,7 +28,6 @@
>>
>>  #include <plat/pincfg.h>
>>  #include <plat/gpio-nomadik.h>
>> -#include <mach/hardware.h>
>>  #include <asm/gpio.h>
>
> While you're here, please replace this with linux/gpio.h - which will give
> us one less direct dependency on asm/ or mach/ includes from drivers.

OK I just deleted it, <linux/gpio.h> was included further up, so
this was just some dangling include anyway.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/