linux-kernel - Re: [PATCH V1 2/2] i2c: tegra: support for I2C_M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120424130118.GD4030@pengutronix.de>
Date:	Tue, 24 Apr 2012 15:01:18 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Laxman Dewangan <ldewangan@...dia.com>, ben-linux@...ff.org,
	swarren@...dotorg.org, olof@...om.net, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V1 2/2] i2c: tegra: support for I2C_M_NOSTART protocol
 mangling

> > * We should allocate a new functionality flag for it.
> > * We should update the documentation to reflect the two use cases.
> 
> That sounds like a good plan.  I'll try to get round to it if nobody
> beats me to it.

Would it make sense to make all four I2C_M_* mangling features seperate
I2C_FUNC_* options? The old I2C_FUNC_PROTOCOL_MANGLING could then be all
four (seperately) exposed mangling features ORed. That's what I was
wondering when looking at the patch.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)