[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdYNNCxK8iZFQOpnSfYdtEUkEmMCH3otQf6Q9vPwUadT0w@mail.gmail.com>
Date: Tue, 24 Apr 2012 15:08:42 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: ciminaghi@...dd.com
Cc: vinod.koul@...el.com, linux-kernel@...r.kernel.org,
dan.j.williams@...el.com, pgeninatti@...t-in.com,
acolosimo@...t-in.com, alarosa@...nintellect.eu
Subject: Re: [PATCH] dmaengine/amba-pl08x : reset phychan_hold on terminate all
On Thu, Apr 19, 2012 at 12:20 PM, <ciminaghi@...dd.com> wrote:
> From: Davide Ciminaghi <ciminaghi@...dd.com>
>
> When a client calls pl08x_control with DMA_TERMINATE_ALL, it is correct
> to terminate and release the phy channel currently in use (if one is in use),
> but the phychan_hold counter must also be reset (otherwise it could get
> trapped in an unbalanced state).
>
> Signed-off-by: Davide Ciminaghi <ciminaghi@...dd.com>
Can't test it right now but looks convincingly correct:
Acked-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists