linux-kernel - Re: [PATCH] kbuild: Add error handling to KCONFIG_ALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Apr 2012 15:37:03 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnaud Lacombe <lacombar@...il.com>,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] kbuild: Add error handling to KCONFIG_ALL_CONFIG

Dne 24.4.2012 14:54, Eric W. Biederman napsal(a):
> Michal Marek <mmarek@...e.cz> writes:
> 
>> On Tue, Apr 24, 2012 at 04:57:39AM -0700, Eric W. Biederman wrote:
>>>  		name = getenv("KCONFIG_ALLCONFIG");
>>> -		if (name && !stat(name, &tmpstat)) {
>>> -			conf_read_simple(name, S_DEF_USER);
>>> +		if (name && name[0] != '\0') {
>>> +			if (conf_read_simple(name, S_DEF_USER)) {
>>> +				fprintf(stderr,
>>> +					_("*** Can't read seed configuration \"%s\"!\n"),
>>> +					name);
>>> +				exit(1);
>>> +			}
>>>  			break;
>>>  		}
>>>  		switch (input_mode) {
>>
>>
>> Before this patch, the code would fall back to a file named
>> all{no,yes,mod,def,random}.config and then to all.config. Now you require
>> $KCONFIG_ALLCONFIG to always be a file. I suggest we keep the fallback at
>> least for KCONFIG_ALLCONFIG=1, like this:
> 
> I don't require KCONFIG_ALLCONFIG to always be a file if it is an
> empty string we continue to fallback to the predefined file names.
> Which is the currently documented behavior.

Ah, right, it says "If KCONFIG_ALLCONFIG is used without a filename, ...".


> As for KCONFIG_ALLCONFIG=1 if people are a actually doing that the
> complexity seems worth it (to not break muscle memory and/or scripts).
> I was just aiming for an absolutely trivial and simple implementation.
> 
> Why do you think people have been specifying KCONFIG_ALLCONFIG=1?
> instead of simply exporting KCONFIG_ALLCONFIG with an empty string?

I have been using KCONFIG_ALLCONFIG=1 :). It's quite natural to set env
variables to "1" to enable something. But I don't insist that this is
retained.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/