linux-kernel - Re: [PATCH] Staging: comedi: fix trailing whitespace and quoted string split across lines in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120424184642.GA20004@kroah.com>
Date:	Tue, 24 Apr 2012 11:46:42 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Stéphane Pajot <pajot.stephane@...il.com>
Cc:	rdunlap@...otime.net, fmhess@...rs.sourceforge.net,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix trailing whitespace and quoted
 string split across lines in ni_labpc.c

On Tue, Apr 24, 2012 at 06:50:10PM +0200, Stéphane Pajot wrote:
> This is a patch to the ni_labpc.c file that fixes up trailing whitespace error and quoted string split across lines warning
> found by the checkpatch.pl tool

Please only fix one type of thing per patch, so this should be a two
patch series at the least.

But...

> @@ -738,7 +738,7 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  		irq = it->options[1];
>  		dma_chan = it->options[2];
>  #else
> -		printk(KERN_ERR " this driver has not been built with ISA DMA "
> +		printk(KERN_ERR " this driver has not been built with ISA DMA\n"
>  								"support.\n");

What?  Why did you do this?  Do you understand what you just did to the
message printed out?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/