linux-kernel - Re: Breaking userspace? Re: 3.0.24 broke aufofs on mixed 32/64bit environment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFw=cfYZO7PWDRRuZw1nYxvUk-63qfVVwfdJWevtmZoOig@mail.gmail.com>
Date:	Tue, 24 Apr 2012 12:53:27 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Michael Tokarev <mjt@....msk.ru>, Thomas Meyer <thomas@...3r.de>
Cc:	Ian Kent <raven@...maw.net>,
	"stable@...nel.org" <stable@...nel.org>, autofs@...r.kernel.org,
	Linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Breaking userspace? Re: 3.0.24 broke aufofs on mixed 32/64bit environment

On Tue, Apr 24, 2012 at 9:12 AM, Michael Tokarev <mjt@....msk.ru> wrote:
>
> The userspace is running debian stable (squeeze).  Debian has autofs
> package based on upstream 5.0.4 version.  That (upstream) version has
> the "bug-compat" code in it, in daemon/automount.c:
>
> static size_t get_kpkt_len(void)
> {
>        size_t pkt_len = sizeof(struct autofs_v5_packet);
>        struct utsname un;
>
>        uname(&un);
>
>        if (pkt_len % 8) {
>                if (strcmp(un.machine, "alpha") == 0 ||
>                    strcmp(un.machine, "ia64") == 0 ||
>                    strcmp(un.machine, "x86_64") == 0 ||
>                    strcmp(un.machine, "ppc64") == 0)
>                        pkt_len += 4;

Ugh.

So how did this break for Thomas Mayer (there was another person
involved too, I forget the details)? Is this code somehow
config-dependent so that it doesn't even get compiled for some cases?

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/