linux-kernel - Re: [PATCH] Staging: comedi: fix trailing whitespace and quoted string split across lines in ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120424200058.GA14071@kroah.com>
Date:	Tue, 24 Apr 2012 13:00:58 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Stéphane Pajot <pajot.stephane@...il.com>
Cc:	devel@...verdev.osuosl.org, fmhess@...rs.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix trailing whitespace and quoted
 string split across lines in ni_labpc.c

On Tue, Apr 24, 2012 at 09:27:09PM +0200, Stéphane Pajot wrote:
> On Tue, Apr 24, 2012 at 11:46:42AM -0700, Greg KH wrote:
> > On Tue, Apr 24, 2012 at 06:50:10PM +0200, Stéphane Pajot wrote:
> > > @@ -738,7 +738,7 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> > >  		irq = it->options[1];
> > >  		dma_chan = it->options[2];
> > >  #else
> > > -		printk(KERN_ERR " this driver has not been built with ISA DMA "
> > > +		printk(KERN_ERR " this driver has not been built with ISA DMA\n"
> > >  								"support.\n");
> > 
> > What?  Why did you do this?  Do you understand what you just did to the
> > message printed out?
> 
> ... It was just to patch this "quoted string split across lines
> warning", i saw this solution on the web. Now i think i understand that
> i cannot modify AT ALL a printk(KERN_ERR* even if it's just with a \n ?

Think about what is actually happening here.  You do know C, right?
What is the output of the line before you made the change, and now
after?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/