linux-kernel - Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor isl29018 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120424210847.GA12611@quad.lixom.net>
Date:	Tue, 24 Apr 2012 14:08:47 -0700
From:	Olof Johansson <olof@...om.net>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Laxman Dewangan <ldewangan@...dia.com>,
	Colin Cross <ccross@...roid.com>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 3/3] ARM: dt: tegra_ventana: als and proximity sensor
 isl29018 support

On Tue, Apr 17, 2012 at 04:35:09PM -0600, Stephen Warren wrote:
> On 04/17/2012 12:45 AM, Laxman Dewangan wrote:
> > Add the device info for ALS and proximity sensor isl29018.
> 
> (There were a ton of irrelevant people CC'd on this patch; I cut them
> out, but kept the lists in case anyone was interested in the replies.
> The most relevant list, linux-tegra, also wasn't CC'd)
> 
> > diff --git a/arch/arm/boot/dts/tegra-ventana.dts b/arch/arm/boot/dts/tegra-ventana.dts
> 
> > +		/* ALS and proximity sensor */
> 
> > +		isl29018: isl29018@44 {
> 
> I don't think the label "isl29018:" serves any purpose; nothing else
> needs to refer to this node.
> 
> I note from http://patchwork.ozlabs.org/patch/132936/ that:
> 
> a) Perhaps the vendor prefix should be "isil" not "isl". Olof, can you
> please comment here?

The standard practice is to use stock tickers, but if companies aren't public
then there isn't much you can do. Like Linus said, use your best judgement and
taste and that's really all we can ask for. :)



-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/