linux-kernel - [PATCH][GIT PULL] ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1335304253.28106.149.camel@gandalf.stny.rr.com>
Date:	Tue, 24 Apr 2012 17:50:53 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Russ Dill <Russ.Dill@...com>
Subject: [PATCH][GIT PULL] ktest.pl: Fix combined usage of BISECT_REVERSE
 and BISECT_SKIP


Linus,

Please pull the latest ktest-v3.4-rc4 tree, which can be found at:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-ktest.git
ktest-v3.4-rc4

Head SHA1: 97f106a13ae6ff0bd8f37763ceab1644a77ca119


Russ Dill (1):
      ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP

----
 tools/testing/ktest/ktest.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---------------------------
commit 2bc90df49d62e213acaaea84b45abd9d6ceaa4c1
Author: Russ Dill <Russ.Dill@...com>
Date:   Mon Apr 23 19:43:00 2012 -0700

    ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
    
    When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
    testing, build failures are treated as boot or test failures and
    'git bisect bad' is executed instead of 'git bisect skip'. This is because
    the $ret value of -1 is treated as a build failure, but the $reverse_bisect
    logic does not properly handle this.
    
    Simple fix, only invert it if it is positive.
    
    Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.com
    
    Signed-off-by: Russ Dill <Russ.Dill@...com>
    Signed-off-by: Steven Rostedt <rostedt@...dmis.org>

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index 95d6a6f..d2ede59 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -2192,7 +2192,7 @@ sub run_bisect {
     }
 
     # Are we looking for where it worked, not failed?
-    if ($reverse_bisect) {
+    if ($reverse_bisect && $ret >= 0) {
 	$ret = !$ret;
     }
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/