linux-kernel - Re: [PATCH 03/11] parse-events: Get rid of handling concatenation on event_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1335227168.28106.126.camel@gandalf.stny.rr.com>
Date:	Mon, 23 Apr 2012 20:26:08 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung.kim@....com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Borislav Petkov <bp@...en8.de>,
	David Ahern <dsahern@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/11] parse-events: Get rid of handling concatenation
 on event_read_print

On Tue, 2012-04-24 at 09:09 +0900, Namhyung Kim wrote:
> Hi,
> 
> On Mon, 23 Apr 2012 12:33:42 -0400, Steven Rostedt wrote:
> > On Mon, 2012-04-23 at 13:58 +0900, Namhyung Kim wrote:
> >> The concatenation of subsequent DQUOTE'd strings is handled
> >> by __read_token() already.
> >> 
> >
> > You missed the point of this concat. It's not connecting "xxx" it is
> > connecting "xxx" "yyy" into "xxxyyy", as some events do this.
> >
> 
> I think I don't :). Please see commit 0f15820 ("parse-events:
> Concatinate two strings that are adjacent").

Heh, OK, I remember doing it for the print statement, but I guess I
needed to do it for the token too. As the commits for both are almost
identical. As the print was first, it must not have been enough, and I
moved it to the token, but kept the first concat there.

I still want to hold off on this patch just to make sure there's not
something else that was missed.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/