linux-kernel - Re: [PATCH v4] set fake_rtable's dst to NULL to avoid kernel Oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120424.001735.1975136616657606100.davem@davemloft.net>
Date:	Tue, 24 Apr 2012 00:17:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peter.huangpeng@...wei.com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org,
	eric.dumazet@...il.com, peter.huangpeng@...il.com,
	linux-kernel@...r.kernel.org, harry.majun@...wei.com,
	ctrix+debianbugs@...ynet.it
Subject: Re: [PATCH v4] set fake_rtable's dst to NULL to avoid kernel Oops

From: "Peter Huang(Peng)" <peter.huangpeng@...wei.com>
Date: Fri, 20 Apr 2012 14:12:51 +0800

> bridge: set fake_rtable's dst to NULL to avoid kernel Oops
> 
> when bridge is deleted before tap/vif device's delete, kernel may
> encounter an oops because of NULL reference to fake_rtable's dst.
> Set fake_rtable's dst to NULL before sending packets out can solve
> this problem.
> 
> v4 reformat, change br_drop_fake_rtable(skb) to {}
> 
> v3 enrich commit header
> 
> v2 introducing new flag DST_FAKE_RTABLE to dst_entry struct.
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Peter Huang <peter.huangpeng@...wei.com>

Applied, although I changed to nop br_drop_fake_rtable() implementation
to use "do { } while (0)" instead of just plain "{ }".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/