linux-kernel - Re: [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling code label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120424052832.GA28787@core.coreip.homeip.net>
Date:	Mon, 23 Apr 2012 22:28:32 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/input/tablet/aiptek.c: adjust error-handling
 code label

On Mon, Apr 16, 2012 at 10:44:52PM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> At the point of this error-handling code, aiptek->urb has been allocated,
> and it does not appear to be less necessary to free it here than in the
> error-handling code just below.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Applied, thank you Julia.

> 
> ---
>  drivers/input/tablet/aiptek.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet/aiptek.c
> index 205d16a..a33d347 100644
> --- a/drivers/input/tablet/aiptek.c
> +++ b/drivers/input/tablet/aiptek.c
> @@ -1856,7 +1856,7 @@ aiptek_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  	if (i == ARRAY_SIZE(speeds)) {
>  		dev_info(&intf->dev,
>  			 "Aiptek tried all speeds, no sane response\n");
> -		goto fail2;
> +		goto fail3;
>  	}
>  
>  	/* Associate this driver's struct with the usb interface.
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/