linux-kernel - Re: [PATCH] alpha: add io{read,write}{16,32}be functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120424055123.GA7140@burratino>
Date:	Tue, 24 Apr 2012 00:51:23 -0500
From:	Jonathan Nieder <jrnieder@...il.com>
To:	Matt Turner <mattst88@...il.com>
Cc:	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
	Michael Cree <mcree@...on.net.nz>,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Ben Hutchings <ben@...adent.org.uk>,
	Raúl Porcel <armin76@...too.org>
Subject: Re: [PATCH] alpha: add io{read,write}{16,32}be functions

Hi Matt et al,

Michael Cree wrote:

> These functions are used in some PCI drivers with big-endian
> MMIO space.
>
> Admittedly it is almost certain that no one this side of the
> Moon would use such a card in an Alpha but it does get us
> closer to being able to build allyesconfig or allmodconfig,
[...]
> --- a/arch/alpha/include/asm/io.h
> +++ b/arch/alpha/include/asm/io.h
> @@ -490,6 +490,11 @@ extern inline void writeq(u64 b, volatile void __iomem *addr)
>  }
>  #endif
>  
> +#define ioread16be(p) be16_to_cpu(ioread16(p))
> +#define ioread32be(p) be32_to_cpu(ioread32(p))
> +#define iowrite16be(v,p) iowrite16(cpu_to_be16(v), (p))
> +#define iowrite32be(v,p) iowrite32(cpu_to_be32(v), (p))
> +
>  #define inb_p		inb

This patch has been in use in Debian's development branch since
January.  Does it look sensible to you?  (If so, I'd like to see it in
mainline eventually so we can more easily share bugfixes depending on
it in the future.)

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/