[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20120425055011.GA978@shangw>
Date: Wed, 25 Apr 2012 13:50:11 +0800
From: Gavin Shan <shangw@...ux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>,
Ryan Wang <openspace.wang@...il.com>,
linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: 3.4-rc3 compile failed on IBM Power6
>> In order to make iommu.c irrelative to CONFIG_EEH, we might figure out
>> the PE number of the PCI device during PCI probe time. Here're some
>> rough thoughts about the rework.
>>
>> - Introduce additional field "int pe_num" to "struct dev_archdata".
>> That would be traced like: (struct pci_dev)->(struct device dev)
>> ->(struct dev_archdata archdata).
>> - During the PCI probe time (maybe pci_fixup_early), we can figure
>> out the PE number.
>>
>> Then we can retrieve the PE number of PCI device from "int pe_num" and needn't
>> care CONFIG_EEH has been turned on or off. I'm not sure Ben has any comments
>> on the idea?
>
>Just select EEH from pseries Kconfig, no point in keeping that a user visible option.
>
Thanks for the suggestion, Ben :-)
I've sent one trivial patch against it.
>Cheers,
>Ben.
>
>
Thanks,
Gavin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists