linux-kernel - Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for braces, comments and casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Apr 2012 10:42:02 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	apw@...onical.com
Subject: Re: Please fix or revert: [PATCH] checkpatch: add --strict tests for
 braces, comments and casts

(Sorry about the late reply, was busy with other things.)

* David Miller <davem@...emloft.net> wrote:

> From: Ingo Molnar <mingo@...nel.org>
> Date: Mon, 16 Apr 2012 22:26:54 +0200
> 
> >     If you don't "see" it as ugly it's simply because your brain
> >     is not wired up to see 3D/2D geometry as a significant
> >     source of information.
> 
> I'm sorry that I'm so handicapped that I cannot match your
> visual capabilitites.

I genuinely think that it's the other way around: if what I say 
above is true then *you* have the superior vision for coding.

Geometric properties of code are a distraction really, they 
don't matter to the end result.

So in reality keeping comments balanced helps *my* disability: 
my inability to ignore functionally irrelevant patterns of 
characters...

So I am asking *you* to do me a favor: please understand my 
perspective and insert a bit more whitespace to keep code 
readable for people like me.

( The wider question is, what is the contribution weighted 
  proportion of the two groups of kernel developers and what is 
  the disutility and utility of the two variants. It's a 
  difficult balancing task and there's no perfect solution. )

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/