linux-kernel - Re: [PATCH RFC v3] vfs: make fstatat retry once on ESTALE errors from getattr call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87bomgkv1b.fsf@tucsk.pomaz.szeredi.hu>
Date:	Wed, 25 Apr 2012 11:41:52 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Jeff Layton <jlayton@...hat.com>
Cc:	Peter Staubach <pstaubach@...grid.com>,
	Steve Dickson <SteveD@...hat.com>,
	"linux-fsdevel\@vger.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-nfs\@vger.kernel.org" <linux-nfs@...r.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
	"viro\@ZenIV.linux.org.uk" <viro@...IV.linux.org.uk>,
	"hch\@infradead.org" <hch@...radead.org>,
	"michael.brantley\@deshaw.com" <michael.brantley@...haw.com>,
	"sven.breuner\@itwm.fraunhofer.de" <sven.breuner@...m.fraunhofer.de>,
	"chuck.lever\@oracle.com" <chuck.lever@...cle.com>,
	"malahal\@us.ibm.com" <malahal@...ibm.com>,
	"bfields\@fieldses.org" <bfields@...ldses.org>,
	"trond.myklebust\@fys.uio.no" <trond.myklebust@....uio.no>,
	"rees\@umich.edu" <rees@...ch.edu>
Subject: Re: [PATCH RFC v3] vfs: make fstatat retry once on ESTALE errors from getattr call

Jeff Layton <jlayton@...hat.com> writes:

>> And an audit would still not ensure safety against future additions of
>> ESTALE.
>> 
>
> Well, nothing is safe from the future. It's incumbent upon us to review
> patches and such before such breakage goes in.

Good interfaces are safe against stupidity, and that very much applies
to the kernel too.  Review is not an excuse for bad interfaces.

> But, let's say for the purposes of argument that we do have a fs (FUSE
> or otherwise) that is persistently returning ESTALE on a lookup. Why
> was Peter's check that we were making forward progress not enough to
> guard against this problem?
>
> In particular, I'm talking about the code he added to link_path_walk in
> this patch to check that the value of nd->path.dentry was changing:
>
>     https://lkml.org/lkml/2008/3/10/266
>
> It seems like that ought to be enough to alleviate your fears on this.
> We could also check for fatal signals on each pass and that would allow
> users to break out of the loop even when the underlying fs doesn't
> handle signals properly.

AFAICS that doesn't ensure progress, only change.  It helps those cases
which persistently return ESTALE, but not cases where there is change
but no progress.  E.g. it doesn't prevent DoS by a client doing renames
over a directory in a tight loop.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/