linux-kernel - Re: [PATCH] twl-regulator: Allow CONFIG_TWL4030_ALLOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120425195956.5b3d9c2a@notabene.brown>
Date:	Wed, 25 Apr 2012 19:59:56 +1000
From:	NeilBrown <neilb@...e.de>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] twl-regulator: Allow CONFIG_TWL4030_ALLOW_UNSUPPORTED
 to be requested.

On Wed, 25 Apr 2012 09:24:18 +0100 Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:

> On Wed, Apr 25, 2012 at 12:29:24PM +1000, NeilBrown wrote:
> > 
> > twl-regulator.c changes behaviour slightly depending on
> >   CONFIG_TWL4030_ALLOW_UNSUPPORTED
> > However that config option is not currently listed in any Kconfig
> > file.
> > So add the option to allow it to be chosen.
> 
> Shouldn't this be hidden behind _EXPERIMENTAL and/or enabled by the
> board in platform data/device tree?  Kconfig feels like the wrong place
> to do this sort of configuration.

That make sense - but I cannot find a good place to put the flag.
TWL doesn't have any twl-specific platform data, it just uses
struct regulator_init_data.  I don't suppose it would be acceptable
to tuck an 'allow_unsupported' flag inside 'struct regulation_constraints'?

I'm not sure how else to do it without fairly major surgery.

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)