linux-kernel - Re: [PATCH 1/4] perf tools: Fix include header files in util/parse-events.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Apr 2012 07:21:24 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Robert Richter <robert.richter@....com>
Cc:	Ingo Molnar <mingo@...nel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] perf tools: Fix include header files in
 util/parse-events.h

Em Tue, Apr 24, 2012 at 07:58:04PM +0200, Robert Richter escreveu:
> On 24.04.12 14:35:55, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Apr 24, 2012 at 06:53:44PM +0200, Robert Richter escreveu:
> > > On 05.04.12 18:26:25, Robert Richter wrote:
> > > > Include header fixes for
> > > > 
> > > > ... bool:
> > > > 
> > > >  util/parse-events.h:31: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘have_tracepoints’
> > > > 
> > > > ... and types.h:
> > > > 
> > > >  util/parse-events.h:28: error: expected ‘)’ before ‘config’
> > > >  util/parse-events.h:34: error: expected declaration specifiers or ‘...’ before ‘u64’
> > > >  util/parse-events.h:45: error: expected ‘)’ before ‘type’
> > > > 
> > > > This happens if now other include files are included before
> > > > util/parse-events.h.
> > > > 
> > > > Signed-off-by: Robert Richter <robert.richter@....com>
> > > 
> > > Arnaldo,
> > > 
> > > is it your intention that you didn't apply this patch?
> > 
> > Is this on perf/urgent or perf/core? In what system does this happen?
> 
> Neither, I stumbled over this while working on a modified version of
> perf tools. The interface definition of util/parse-events.h contains
> type bool and u64, but both are not defined. Thus, including
> parse-events.h independently of other header files will raise this
> compile errors. It took me some time to figure out what happened so I
> think it is worth fixing it.

Cool, that explains why I have not stumbled on it, thanks for
explaining, will apply.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/