linux-kernel - Re: [PATCH v2 1/2] pinctrl: add pinctrl_provide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Apr 2012 13:19:43 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Dong Aisheng <aisheng.dong@...escale.com>
Cc:	Stephen Warren <swarren@...dotorg.org>,
	Dong Aisheng-B29396 <B29396@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH v2 1/2] pinctrl: add pinctrl_provide_dummies interface for
 platforms to use

On Wed, Apr 25, 2012 at 11:49 AM, Dong Aisheng
<aisheng.dong@...escale.com> wrote:
> On Wed, Apr 25, 2012 at 03:00:23AM +0800, Stephen Warren wrote:

>> The only thing that should be calling pinctrl_request_gpio() is a GPIO
>> driver. It should only be calling it for the GPIOs it manages. I'd
>> expect that if a platform's pinctrl driver was not yet written to
>> support the GPIO functionality, then the GPIO driver would not be
>> calling this function.
>>
> Hmm, pinctrl gpio is in the same situation as pinctrl state that gpio
> driver may be shared between several platforms, with pinctrl support
> or not.

I think it's mostly safe to assume that either:

- pinctrl calls from GPIO drivers gets stubbed out totally due to
  CONFIG_PINCTRL not being selected

or:

- You need to pass a token through platform data to the
  GPIO driver telling it whether it needs to request pins for
  it's GPIOs or not. Just a bool should work fine?

Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/