[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120425113414.GA3378@m.brq.redhat.com>
Date: Wed, 25 Apr 2012 13:34:15 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ftrace: Remove unused code ftrace related code
On Wed, Apr 25, 2012 at 07:21:29AM -0400, Steven Rostedt wrote:
> On Wed, 2012-04-25 at 10:23 +0200, Jiri Olsa wrote:
> > Removing unused functions:
> > ftrace_rec_iter_record
> > ftrace_rec_iter_next
> > ftrace_rec_iter_start
> > ftrace_location
>
> No, no, no!!
>
> These are used in the core infrastructure of removing stop machine from
> ftrace.
>
> Correct, no one currently uses them, but that's because they were needed
> for the arch dependent code. I have patches for both PPC and x86 to
> remove stop machine, and I want the PPC changes to go through the PPC
> tree.
>
> I pushed the changes for the core infrastructure so that we don't have
> dependencies between different archs.
>
> Please read: commit c88fd8634ea68e74c7d19fd2621b4078fd22864c
>
> If you remove these you would break:
>
> https://lkml.org/lkml/2012/4/23/620
>
> Big NACK!
I see, thought they were just leftover not seeing any user..
big sorry then ;-)
jirka
>
> -- Steve
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists