linux-kernel - Re: [PATCH v2 2/2] pinctrl: remove the old pinctrl dt dummy state interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120425120509.GC17631@shlinux2.ap.freescale.net>
Date:	Wed, 25 Apr 2012 20:05:10 +0800
From:	Dong Aisheng <aisheng.dong@...escale.com>
To:	Stephen Warren <swarren@...dotorg.org>
CC:	Dong Aisheng-B29396 <B29396@...escale.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linus.walleij@...ricsson.com" <linus.walleij@...ricsson.com>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH v2 2/2] pinctrl: remove the old pinctrl dt dummy state
 interfaces

On Wed, Apr 25, 2012 at 03:04:27AM +0800, Stephen Warren wrote:
> On 04/24/2012 03:33 AM, Dong Aisheng wrote:
> > From: Dong Aisheng <dong.aisheng@...aro.org>
> > 
> > We already have pinctrl_provide_dummies, so remove the old
> > one to avoid diversity.
> 
> Nak, if I may be so bold.
> 
No, it's fine to me.
Since i'm not sure this patch is really needed, so i sent it out to
request for your comment.

> > Hi Stephen,
> > I removed the old dt pinctrl dummy sate interface.
> > The purpose is to get a unified way to handle pinctrl dummy state.
> 
> Well, there are two completely different scenarios being covered here,
> and I don't think it makes sense to unify them:
> 
> 1) Platform under development without complete pinctrl support yet
> (covered by patch 1 in this series).
> 
> 2) Platform with complete pinctrl support, but using some common HW
> modules whose drivers need to use pinctrl on some platforms, but not on
> all, so that dummy states are required. This patch removes the ability
> to correctly represent this situation.
> 
Looks reasonable to me.

> > One disadvantage is that we may not meet the requirement
> > that for platform which only want to use dummy state for some specific
> > devices while not affect others. For this case, it may reply on users
> > to refer to the pinctrl debug message to see which devices are using
> > dummy state while which are not.
> > However, if keep it we may have two type of user interface to handle
> > dummy state which i'm not sure is a good thing. And as regulator also
> > does not provide per device dummies, so i removed it first.
> 
> Well, first I'd say that if regulator didn't have this feature, it'd
> probably just be a missing feature in regulator, and not a good
> justification for removing the feature from pinctrl.
> 
> But that said, regulator does in fact have this feature - it's called
> the fixed regulator.
> 
Yes, i see.

> > What's your suggestion on it?
> > I reform this clean up into a separate patch, if you do not like it,
> > we can drop it later.
> 
> I'd love to drop it, please.
Okay, we can drop it.

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/