lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Apr 2012 13:38:55 +0200 From: Karol Lewandowski <k.lewandowsk@...sung.com> To: Wolfram Sang <w.sang@...gutronix.de> Cc: m.szyprowski@...sung.com, ben-linux@...ff.org, thomas.abraham@...aro.org, linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org, linux-samsung-soc@...r.kernel.org, t.stanislaws@...sung.com, kyungmin.park@...sung.com, broonie@...nsource.wolfsonmicro.com, "grant.likely@...retlab.ca" <grant.likely@...retlab.ca> Subject: Re: [PATCH 1/2] i2c-s3c2410: Rework device type handling On 24.04.2012 16:44, Wolfram Sang wrote: > On Tue, Apr 24, 2012 at 10:40:49AM +0200, Karol Lewandowski wrote: >> On 23.04.2012 20:20, Wolfram Sang wrote: >>>> + if (pdev->dev.of_node) { >>>> + const struct of_device_id *match; >>>> + match = of_match_node(&s3c24xx_i2c_match, pdev->dev.of_node); >>> >>> I'd appreciate a comment explaining why match can't be NULL here (as to >>> my understanding, it can't). Or just check for it, but this way it looks >>> a bit fishy and people (hopefully ;)) will ask about it. >> >> >> My understanding is that it can't be null for exactly same reason why >> platform_get_device_id(pdev) can't be null either (see below). >> >> I.e. prerequisite for this code to be run at all (as it's called from >> driver's .probe()) is to be already matched against very same match >> table. > > Yes, I agree. Yet, this is not obvious and people might try to fix it > (especially since programs like smatch report it as potentially > dangerous). Ah, whatever, I could simply apply the fix then :) OK. Great! I hope it won't cause any problems. :) Regards, -- Karol Lewandowski | Samsung Poland R&D Center | Linux/Platform -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists