linux-kernel - Re: [PATCH 0/6] zsmalloc: clean up and fix arch dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F97F0F1.2000506@vflare.org>
Date:	Wed, 25 Apr 2012 08:41:21 -0400
From:	Nitin Gupta <ngupta@...are.org>
To:	Minchan Kim <minchan@...nel.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 0/6] zsmalloc: clean up and fix arch dependency

Hi Minchan,

On 04/25/2012 02:23 AM, Minchan Kim wrote:

> This patchset has some clean up patches(1-5) and remove 
> set_bit, flush_tlb for portability in [6/6].
> 
> Minchan Kim (6):
>   zsmalloc: use PageFlag macro instead of [set|test]_bit
>   zsmalloc: remove unnecessary alignment
>   zsmalloc: rename zspage_order with zspage_pages
>   zsmalloc: add/fix function comment
>   zsmalloc: remove unnecessary type casting
>   zsmalloc: make zsmalloc portable
> 
>  drivers/staging/zsmalloc/Kconfig         |    4 --
>  drivers/staging/zsmalloc/zsmalloc-main.c |   73 +++++++++++++++++-------------
>  drivers/staging/zsmalloc/zsmalloc_int.h  |    3 +-
>  3 files changed, 43 insertions(+), 37 deletions(-)
> 


Thanks for the fixes.


Your description is missing testing notes (especially since patch [6/6]
is not a cosmetic change). So, can you please add these either here in
patch 0 or as part of patch 6/6 description?

Thanks,
Nitin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/