linux-kernel - RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors from the host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <426367E2313C2449837CD2DE46E7EAF92D7187@SN2PRD0310MB382.namprd03.prod.outlook.com>
Date:	Wed, 25 Apr 2012 12:50:24 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>
Subject: RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle
 errors from the host



> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@...senPartnership.com]
> Sent: Wednesday, April 25, 2012 4:53 AM
> To: KY Srinivasan
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; ohering@...e.com;
> hch@...radead.org; linux-scsi@...r.kernel.org; apw@...onical.com
> Subject: RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors
> from the host
> 
> On Wed, 2012-04-18 at 12:38 +0000, KY Srinivasan wrote:
> >
> > > -----Original Message-----
> > > From: KY Srinivasan
> > > Sent: Tuesday, April 10, 2012 11:14 AM
> > > To: KY Srinivasan; gregkh@...uxfoundation.org; linux-
> kernel@...r.kernel.org;
> > > devel@...uxdriverproject.org; virtualization@...ts.osdl.org;
> ohering@...e.com;
> > > jbottomley@...allels.com; hch@...radead.org; linux-scsi@...r.kernel.org;
> > > apw@...onical.com
> > > Subject: RE: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors
> > > from the host
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: K. Y. Srinivasan [mailto:kys@...rosoft.com]
> > > > Sent: Thursday, April 05, 2012 3:27 PM
> > > > To: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> > > > devel@...uxdriverproject.org; virtualization@...ts.osdl.org;
> ohering@...e.com;
> > > > jbottomley@...allels.com; hch@...radead.org; linux-scsi@...r.kernel.org;
> > > > apw@...onical.com
> > > > Cc: KY Srinivasan
> > > > Subject: [PATCH RESEND 1/1] Drivers: scsi: storvsc: Properly handle errors
> from
> > > > the host
> > > >
> > > > If the host returns error for pass through commands, deal with them
> > > > appropriately. I would like to thank James for patiently helping
> > > > me with this patch.
> > >
> > > James,
> > >
> > > Thank you for suggesting the fix here. I hope this is what you were looking
> for.
> > >
> > > Regards,
> > >
> > > K. Y
> 
> OK, I have the patch, but the change log is a bit rubbish.  I changed it
> to
> 
> Hyper-V cannot process some commands like ATA_12 and ATA_16. It also returns
> a
> very generic error when this happens (SRB_STATUS_ERROR).  Most of the time
> we
> treat SRB_STATUS_ERROR as DID_TARGET_FAILURE which causes error handler
> retry,
> but in the case of pass through commands, they'll never succeed (and the error
> handler will offline the device), so put a discriminating block in the command
> completion routing and send the SRB_STATUS_ERROR upwards with
> DID_PASSTHROUGH
> for commands we know should not be retried.

Looks good; thanks James.

K. Y