linux-kernel - Re: [PATCH v2] dmaengine: care sd_dma_address/len in dmaengine_prep_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F9807AF.3000804@metafoo.de>
Date:	Wed, 25 Apr 2012 16:18:23 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dmaengine: care sd_dma_address/len in dmaengine_prep_slave_single()

On 02/01/2012 07:22 PM, Russell King - ARM Linux wrote:
> On Mon, Jan 30, 2012 at 05:13:30PM -0800, Kuninori Morimoto wrote:
>> +	sg_init_table(&sg, 1);
>> +	sg_set_page(&sg, pfn_to_page(PFN_DOWN(buf)),
>> +		    len, offset_in_page(buf));
> 
> There's not much point setting this - the page/virtual address should
> not be used by DMA engines as that may not reflect what's being requested
> (especially if there's an IOMMU in the way.)

I was just looking at this again and there are actually quite a few dma
engine drivers which use sg->length and sg_phys(sg). I guess these would
break if the sg_set_page was to be removed. Should these drivers be changed
to use sg_dma_len and sg_dma_address?

Thanks
- Lars
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/