| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACRpkdb=aXHrXWEEZHpJup-rzd385Rew6QfF=ZhPRM8pBs+8hQ@mail.gmail.com> Date: Wed, 25 Apr 2012 19:06:06 +0200 From: Linus Walleij <linus.walleij@...aro.org> To: Andreas Schallenberg <Andreas.Schallenberg@...itytechnica.com> Cc: grant.likely@...retlab.ca, linus.walleij@...ricsson.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] Add support for TCA6424A On Wed, Apr 25, 2012 at 3:18 PM, Andreas Schallenberg <Andreas.Schallenberg@...itytechnica.com> wrote: > From 3fcb45bad283740a48c17ff078c28dd1354204ae Mon Sep 17 00:00:00 2001 > From: Andreas Schallenberg <Andreas.Schallenberg@...itytechnica.com> > Date: Wed, 25 Apr 2012 14:51:30 +0200 > Subject: [PATCH] Add support for TCA6424A > > This patch extends the PCA953x driver to support TI's TCA6424A 24 bit I2C I/O expander. > The patch is on code by Michele Bevilacqua. > > Changes in v2: > - Compare ngpio against 24 in both places, not >16 > - Larger datatype now u32 instead of uint. > Bit fields not used for struct members since their address is taken. > - Be precise: TCA6424A (untested for older TCA6424) > > Should the chip name string read tca6424a as well? > > Signed-off-by: Andreas Schallenberg<Andreas.Schallenberg@...itytechnica.com> Looks good to me. Would be good to have this tested on the other family members though. Acked-by: Linus Walleij <linus.walleij@...aro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists