linux-kernel - Re: [PATCH] implement uid and gid mount options for ext2, ext3 and ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F985A39.4060804@landley.net>
Date:	Wed, 25 Apr 2012 15:10:33 -0500
From:	Rob Landley <rob@...dley.net>
To:	Ludwig Nussel <ludwig.nussel@...e.de>
CC:	linux-kernel@...r.kernel.org,
	"Jan Kara (maintainer:EXT2 FILE SYSTEM)" <jack@...e.cz>,
	"Andrew Morton (maintainer:EXT3 FILE SYSTEM)" 
	<akpm@...ux-foundation.org>,
	"Andreas Dilger (maintainer:EXT3 FILE SYSTEM)" 
	<adilger.kernel@...ger.ca>,
	"\"Theodore Ts'o\" (maintainer:EXT4 FILE SYSTEM)" <tytso@....edu>,
	linux-ext4@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] implement uid and gid mount options for ext2, ext3 and
 ext4

On 04/25/2012 06:54 AM, Ludwig Nussel wrote:
> Rob Landley wrote:
>> On 04/24/2012 10:29 AM, Ludwig Nussel wrote:
>>> Further development of a patch I sent years ago. I didn't find the
>>> time to address the concerns raised back then and forgot about the
>>> patch. Now here it is again.
>>
>> The doc bits look fine:
>>
>> Acked-by: Rob Landley <rob@...dley.net>
>>
>> As for the design: why isn't this in the VFS instead of in ext234? It
>> seems like VFAT is more likely to need this, and I vaguely recall virtfs
>> (I.E. 9pfs) doing something similar...?
> 
> Yes, file systems like FAT that do not store ownership information
> themselves have a uid option. I agree that handling that in vfs itself
> would be the more generic solution. It would require more work though.

The right thing to do is often more work.  If it allows us to remove
existing duplicate code, even better...

Rob
-- 
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation.  Pick one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/