linux-kernel - Re: [PATCH] mm: nobootmem: Correct alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120425201246.GB8989@google.com>
Date:	Wed, 25 Apr 2012 13:12:46 -0700
From:	Tejun Heo <tj@...nel.org>
To:	David Miller <davem@...emloft.net>
Cc:	linux-kernel@...r.kernel.org, yinghai@...nel.org,
	torvalds@...ux-foundation.org
Subject: Re: [PATCH] mm: nobootmem: Correct alloc_bootmem semantics.

On Wed, Apr 25, 2012 at 04:10:50PM -0400, David Miller wrote:
> 
> The comments above __alloc_bootmem_node() claim that the code will
> first try the allocation using 'goal' and if that fails it will
> try again but with the 'goal' requirement dropped.
> 
> Unfortunately, this is not what the code does, so fix it to do so.
> 
> This is important for nobootmem conversions to architectures such
> as sparc where MAX_DMA_ADDRESS is infinity.
> 
> On such architectures all of the allocations done by generic spots,
> such as the sparse-vmemmap implementation, will pass in:
> 
> 	__pa(MAX_DMA_ADDRESS)
> 
> as the goal, and with the limit given as "-1" this will always fail
> unless we add the appropriate fallback logic here.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/