linux-kernel - Re: [BUG]memblock: fix overflow of array index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F987DE5.5030000@linux.intel.com>
Date:	Wed, 25 Apr 2012 15:42:45 -0700
From:	"H. Peter Anvin" <hpa@...ux.intel.com>
To:	David Miller <davem@...emloft.net>
CC:	tj@...nel.org, htmldeveloper@...il.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu, linux-mm@...ck.org
Subject: Re: [BUG]memblock: fix overflow of array index

On 04/25/2012 03:31 PM, David Miller wrote:
> From: "H. Peter Anvin" <hpa@...ux.intel.com>
> Date: Wed, 25 Apr 2012 15:29:31 -0700
> 
>> On 04/25/2012 03:28 PM, Tejun Heo wrote:
>>>
>>> All indexes in memblock are integers.  Changing that particular one to
>>> unsigned int doesn't fix anything.  I think it just makes things more
>>> confusing.  If there ever are cases w/ more then 2G memblocks, we're
>>> going for 64bit not unsigned.
>>>
>>
>> I would expect there to be plenty of memblocks larger than 2G?
> 
> Yes, but not the array indexes into those memblock entries, which is
> what this patch is about.

OIC... more than 2^31 memblocks.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/