linux-kernel - Re: [RFC][PATCH 2/3] math128: Introduce {mult,add,cmp}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120425102342.45cf5c5e81e8aeb3bec67d0b@canb.auug.org.au>
Date:	Wed, 25 Apr 2012 10:23:42 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Juri Lelli <juri.lelli@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH 2/3] math128: Introduce {mult,add,cmp}_u128

Hi Peter,

On Tue, 24 Apr 2012 18:10:41 +0200 Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
>
> Grow rudimentary u128 support without relying on gcc/libgcc.
> 
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> ---
>  arch/alpha/include/asm/math128.h      |    4 ++
>  arch/arm/include/asm/math128.h        |    4 ++
>  arch/avr32/include/asm/math128.h      |    4 ++
>  arch/blackfin/include/asm/math128.h   |    4 ++
>  arch/c6x/include/asm/math128.h        |    4 ++
>  arch/cris/include/asm/math128.h       |    4 ++
>  arch/frv/include/asm/math128.h        |    4 ++
>  arch/h8300/include/asm/math128.h      |    4 ++
>  arch/hexagon/include/asm/math128.h    |    4 ++
>  arch/ia64/include/asm/math128.h       |    4 ++
>  arch/m32r/include/asm/math128.h       |    4 ++
>  arch/m68k/include/asm/math128.h       |    4 ++
>  arch/microblaze/include/asm/math128.h |    4 ++
>  arch/mips/include/asm/math128.h       |    4 ++
>  arch/mn10300/include/asm/math128.h    |    4 ++
>  arch/openrisc/include/asm/math128.h   |    4 ++
>  arch/parisc/include/asm/math128.h     |    4 ++
>  arch/powerpc/include/asm/math128.h    |    4 ++
>  arch/s390/include/asm/math128.h       |    4 ++
>  arch/score/include/asm/math128.h      |    4 ++
>  arch/sh/include/asm/math128.h         |    4 ++
>  arch/sparc/include/asm/math128.h      |    4 ++
>  arch/tile/include/asm/math128.h       |    4 ++
>  arch/um/include/asm/math128.h         |    4 ++
>  arch/unicore32/include/asm/math128.h  |    4 ++
>  arch/x86/include/asm/math128.h        |    4 ++
>  arch/xtensa/include/asm/math128.h     |    4 ++
>  include/linux/math128.h               |   47 ++++++++++++++++++++++++++++++++++

Isn't this what asm-generic is for?  You put the generic version in
asm-generic/math128.h and then add "generic-y += math128.h" to
arch/*/include/asm/Kbuild for each arch that wants the generic version.
Then just include asm/math128.h in linux/math128.h.  Any arch that wants
to optimise these can then just provide its own math128.h.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped