linux-kernel - RE: [PATCH 3/5] mfd: tps65090: Convert to devm_regmap_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D958900912E20642BCBC71664EFECE3E6DD76B0EF0@BGMAIL02.nvidia.com>
Date:	Wed, 25 Apr 2012 10:50:45 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>
Subject: RE: [PATCH 3/5] mfd: tps65090: Convert to devm_regmap_init_i2c()

Thanks for the patch.
Acked by: Venu Byravarasu<vbyravarasu@...dia.com>


> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...il.com]
> Sent: Wednesday, April 25, 2012 7:35 AM
> To: linux-kernel@...r.kernel.org
> Cc: Samuel Ortiz; Venu Byravarasu
> Subject: [PATCH 3/5] mfd: tps65090: Convert to devm_regmap_init_i2c()
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/tps65090.c |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index da821d9..3e12bba 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -283,8 +283,8 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  		}
>  	}
> 
> -	tps65090->rmap = regmap_init_i2c(tps65090->client,
> -		&tps65090_regmap_config);
> +	tps65090->rmap = devm_regmap_init_i2c(tps65090->client,
> +					      &tps65090_regmap_config);
>  	if (IS_ERR(tps65090->rmap)) {
>  		ret = PTR_ERR(tps65090->rmap);
>  		dev_err(&client->dev, "regmap_init failed with err: %d\n", ret);
> @@ -296,14 +296,11 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  	if (ret) {
>  		dev_err(&client->dev, "add mfd devices failed with err: %d\n",
>  			ret);
> -		goto err_regmap_exit;
> +		goto err_irq_exit;
>  	}
> 
>  	return 0;
> 
> -err_regmap_exit:
> -	regmap_exit(tps65090->rmap);
> -
>  err_irq_exit:
>  	if (client->irq)
>  		free_irq(client->irq, tps65090);
> @@ -316,7 +313,6 @@ static int __devexit tps65090_i2c_remove(struct
> i2c_client *client)
>  	struct tps65090 *tps65090 = i2c_get_clientdata(client);
> 
>  	mfd_remove_devices(tps65090->dev);
> -	regmap_exit(tps65090->rmap);
>  	if (client->irq)
>  		free_irq(client->irq, tps65090);
> 
> --
> 1.7.5.4
> 
>