linux-kernel - Re: [PATCH] Input: twl4030 power button: don't lose presses on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120425152603.3d24547f@notabene.brown>
Date:	Wed, 25 Apr 2012 15:26:03 +1000
From:	NeilBrown <neilb@...e.de>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: twl4030 power button: don't lose presses on
 resume

On Tue, 24 Apr 2012 22:09:19 -0700 Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:

> Hi Neil,
> 
> On Wed, Apr 25, 2012 at 12:21:39PM +1000, NeilBrown wrote:
> > 
> > If we press and release the power button before the press interrupt is
> > handled - as can happen on resume - we lose the press event so the
> > release event is ignored and we don't know what happened to cause the
> > wakeup.
> 
> What kind of latency do you observe?

When I have debugging enabled, hundreds of milliseconds.

When I don't have debugging enabled ... it doesn't tell me, but I'm fairly
sure it is several tens of milliseconds and the button press can be quicker
than that.

If it will help I can try to instrument the driver and get some timings.

> 
> > 
> > So make sure that each interrupt handled does generate an event.
> > Because twl4030 queues interrupt events we will see two interrupts
> > for a press-release even if we handle the first one later.  This means
> > that such a sequence will be reported as two button presses.  This
> > is unfortunate but is better than no button presses.
> > Possibly we could set the PENDDIS_MASK to disable queuing of
> > interrupts, but that might adversely affect other interrupt sources.
> >
> 
> It looks like we'd have to modify every driver to ensure consistent
> behavior as we do not have any guarantees on how long resume takes.
> Maybe this is something that input core needs to implement?

Well if every driver is buggy....

I don't see how this could be implemented in the input core.  And even if it
was, you'd probably need to change each driver to interact with this new
functionality which would be much the same work as changing them to work with
the current functionality....
But maybe I have no imagination - if you can suggest a way that the input core
could support this without changing the drivers, I'm happy to try it out.

Thanks,
NeilBrown

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)